changes to reflect current packages on offer on the download-site. #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OR download page no longer uses the term "kit" for different packages. It also no longer offers a "traditional windows kit" without embedded java.
changes to reflect current packages on offer on the download-site.
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-open-refine/compare/md-outputs..md-outputs-PR-349 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-06-18 13:14:03 +0000 |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
Auto-generated via {sandpaper}
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
|
I don't think there is the need for any further changes but just for complete clarity, OpenRefine itself does still offer It also the "windows without embedded java" option but only via Github and not on the download page. I mention only for completeness and do not suggest any further changes to the lesson |
|
You're absolutely right (although there does not seem to be a version without java for win from 3.8 onwards). I just thought since the lesson is referring to the download-page it would be confusing to mention things that are nowhere to be found there. Maybe I should have raised this as an issue first... |
|
I might have been too fast to approve. Thanks for starting the PR. I'll
move a bit slower.
…On Thu, Jun 20, 2024, 3:25 PM r0man-ist ***@***.***> wrote:
You're absolutely right (although there does not seem to be a version
without java for win from 3.8 onwards). I just thought since the lesson is
referring to the download-page it would be confusing to mention things that
are nowhere to be found there. Maybe I should have raised this as an issue
first...
—
Reply to this email directly, view it on GitHub
<#349 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMT5MX5IG4EC3PLZRZO27PDZIM3EFAVCNFSM6AAAAABJQAP7YGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBRGQ4TSOBYGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
@jas58 I think the outcome was the same - this is the right change so I don't think you were too hasty - good to get the update done quickly :) |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 25, 2024
Auto-generated via {sandpaper}
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
Auto-generated via {sandpaper}
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
Auto-generated via {sandpaper}
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
Auto-generated via {sandpaper}
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
Auto-generated via {sandpaper}
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
Auto-generated via {sandpaper}
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
Auto-generated via {sandpaper}
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
Auto-generated via {sandpaper}
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
Auto-generated via {sandpaper}
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
Auto-generated via {sandpaper}
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
Auto-generated via {sandpaper}
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
Auto-generated via {sandpaper}
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
Auto-generated via {sandpaper}
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Auto-generated via {sandpaper}
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
Auto-generated via {sandpaper}
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
Auto-generated via {sandpaper}
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
Auto-generated via {sandpaper}
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Auto-generated via {sandpaper}
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
Auto-generated via {sandpaper}
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
Auto-generated via `{sandpaper}`
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
Auto-generated via `{sandpaper}`
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
Auto-generated via `{sandpaper}`
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
Auto-generated via `{sandpaper}`
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
Auto-generated via `{sandpaper}`
Source : 5bad9b5
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-19 20:50:36 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 26600d7
Branch : main
Author : Jennifer Stubbs <[email protected]>
Time : 2024-06-19 20:49:49 +0000
Message : Merge pull request #349 from r0man-ist/main
changes to reflect current packages on offer on the download-site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OR download page no longer uses the term "kit" for different packages. It also no longer offers a "traditional windows kit" without embedded java, as far as I can see.